Skip to content

Fix build error when alloc feature is disabled#11

Merged
carllerche merged 2 commits into
masterfrom
taiki-e/no-alloc
May 11, 2021
Merged

Fix build error when alloc feature is disabled#11
carllerche merged 2 commits into
masterfrom
taiki-e/no-alloc

Conversation

@taiki-e
Copy link
Copy Markdown
Member

@taiki-e taiki-e commented May 11, 2021

Fixes build error by the way mentioned in #10 (comment).

print only variant name when alloc feature is disabled? (like the following)

#[cfg(feature = "alloc")]
let name = format!("{}::{}", self.name, variant.name());
#[cfg(not(feature = "alloc"))]
let name = variant.name();

@taiki-e taiki-e requested a review from carllerche May 11, 2021 19:14
taiki-e
taiki-e commented May 11, 2021
View reviewed changes
Comment thread .github/workflows/ci.yml Outdated
run: rustup update stable
- name: Install cargo-hack
run: cargo install cargo-hack
- run: cargo hack build --workspace --feature-powerset --no-dev-deps
Copy link
Copy Markdown
Member Author

@taiki-e taiki-e May 11, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, our MSRV is 1.51 (because we use min const generics), so we can use resolver = "2" that the more preferable than --no-dev-deps (that edit Cargo.toml).

UPDATE: done in 013dca6

@taiki-e taiki-e mentioned this pull request May 11, 2021
Merged
@carllerche carllerche merged commit eba3f71 into master May 11, 2021
@taiki-e taiki-e deleted the taiki-e/no-alloc branch May 12, 2021 01:27
@taiki-e taiki-e mentioned this pull request Dec 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carllerche carllerche carllerche approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@taiki-e @carllerche